Opened 5 years ago
Closed 5 years ago
#37048 closed defect (bug) (fixed)
Unapproved comments show publicly when using custom page parameter
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | critical | Version: | 4.4.1 |
Component: | Comments | Keywords: | |
Focuses: | Cc: |
Description
The fix for #35175 adds code which does a manual comment query when wp_list_comments is called with args that don't match the main query (eg a page parameter).
However, the fix queries comments with 'status=all'. This means it includes unapproved comments - so any theme which uses a custom page parameter results in all unapproved comments showing up publicly.
This is a major issue.
@boonebgorges
Change History (4)
Note: See
TracTickets for help on using
tickets.
Perhaps should match the 'default' logic where unapproved comments for the current user are included too? Ie something like (sorry, don't have things set up to add patches easily myself right now):