WordPress.org

Make WordPress Core

#37076 closed defect (bug) (fixed)

Add de_ch and de_ch_informal to remove_accents custom German rules

Reported by: grapplerulrich Owned by: DrewAPicture
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

de_DE and de_DE_formal are already added. It would be really nice if we could could support the DE_CH version too.

Attachments (3)

37076.patch (1.2 KB) - added by grapplerulrich 14 months ago.
37076.1.patch (1.2 KB) - added by grapplerulrich 14 months ago.
37076.2.patch (1.5 KB) - added by grapplerulrich 14 months ago.

Download all attachments as: .zip

Change History (13)

#1 @grapplerulrich
14 months ago

  • Keywords has-patch added

Have added a patch

#2 @TobiasBg
14 months ago

Formal/informal seems to be mixed up in patch, between docs and the locale name.

#3 @grapplerulrich
14 months ago

Ah, thanks, updated the patch

#4 @DrewAPicture
14 months ago

This is a good start. Two things:

  1. There should be a changelog entry for the new locale support. Something like this would be OK:
    * @since 4.6.0 Locale support was added for `de_CH` and `de_CH_formal`.
    
  1. In the table description, there's a missing comma and we should use the expecting casing of the language codes, e.g. ge_CH, ge_CH_formal.

#5 follow-up: @grapplerulrich
14 months ago

@DrewAPicture Thank you for your comments. I don't fully understand what you mean with the second point.

#6 in reply to: ↑ 5 @DrewAPicture
14 months ago

Replying to grapplerulrich:

@DrewAPicture Thank you for your comments. I don't fully understand what you mean with the second point.

In the table description, there's a missing comma

A serial comma should be used to list the locales: "German (de_DE), German formal (de_DE_formal), German (Switzerland) formal (de_ch), and German (Switzerland) informal (de_ch_informal) locales:"

and we should use the expecting casing of the language codes, e.g. ge_CH, ge_CH_formal.

The language codes shouldn't be all lowercase in the table description. de_ch_informal vs de_CH_informal.

#7 follow-up: @grapplerulrich
14 months ago

I have updated a new patch. I am not used to using the serial comma. Is the use of the serial comma documented anywhere?

#8 in reply to: ↑ 7 @DrewAPicture
14 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.6

Replying to grapplerulrich:

I have updated a new patch. I am not used to using the serial comma. Is the use of the serial comma documented anywhere?

It's in the #Grammar section of the PHP Documentation Standards.

37076.2.patch looks great :-)

#9 @ocean90
14 months ago

  • Focuses administration removed
  • Owner set to DrewAPicture
  • Status changed from new to assigned
  • Version trunk deleted

#10 @SergeyBiryukov
14 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37698:

I18N: In remove_accents(), add support for de_CH and de_CH_informal.

Props grapplerulrich.
Fixes #37076.

Note: See TracTickets for help on using tickets.