Opened 9 years ago
Closed 9 years ago
#37076 closed defect (bug) (fixed)
Add de_ch and de_ch_informal to remove_accents custom German rules
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
de_DE
and de_DE_formal
are already added. It would be really nice if we could could support the DE_CH version too.
Attachments (3)
Change History (13)
#4
@
9 years ago
This is a good start. Two things:
- There should be a changelog entry for the new locale support. Something like this would be OK:
* @since 4.6.0 Locale support was added for `de_CH` and `de_CH_formal`.
- In the table description, there's a missing comma and we should use the expecting casing of the language codes, e.g.
ge_CH
,ge_CH_formal
.
#5
follow-up:
↓ 6
@
9 years ago
@DrewAPicture Thank you for your comments. I don't fully understand what you mean with the second point.
#6
in reply to:
↑ 5
@
9 years ago
Replying to grapplerulrich:
@DrewAPicture Thank you for your comments. I don't fully understand what you mean with the second point.
In the table description, there's a missing comma
A serial comma should be used to list the locales: "German (de_DE
), German formal (de_DE_formal
), German (Switzerland) formal (de_ch
), and German (Switzerland) informal (de_ch_informal
) locales:"
and we should use the expecting casing of the language codes, e.g.
ge_CH
,ge_CH_formal
.
The language codes shouldn't be all lowercase in the table description. de_ch_informal
vs de_CH_informal
.
#7
follow-up:
↓ 8
@
9 years ago
I have updated a new patch. I am not used to using the serial comma. Is the use of the serial comma documented anywhere?
#8
in reply to:
↑ 7
@
9 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 4.6
Replying to grapplerulrich:
I have updated a new patch. I am not used to using the serial comma. Is the use of the serial comma documented anywhere?
It's in the #Grammar section of the PHP Documentation Standards.
37076.2.patch looks great :-)
Have added a patch