WordPress.org

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #37077, comment 1


Ignore:
Timestamp:
06/14/2016 10:14:17 PM (3 years ago)
Author:
chadschulz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #37077, comment 1

    v2 v3  
    33Turns out one of the plugins I'm using, Shield WordPress Security, uses that kind of function. So this might all be a (fixable) bug inside HHVM.
    44
    5 However, this sort of "glitch" should still not be allowed through core as the point of this particular `!is_scalar()` conditional is to filter out junk that won't pass `rawurlencode()`. And `!is_string()` isn't any slower that `!is_scalar()`--initial benchmarks show it might actually be a tad faster. It's also more specific to this purpose.
     5However, this sort of "glitch" should still not be allowed through core as the point of this particular `!is_scalar()` conditional is to filter out junk that won't pass `rawurlencode()`. And `!is_string()` isn't any slower that `!is_scalar()`--initial benchmarks show it might actually be a tad faster. It's also more specific to this purpose.
     6
     7''--None of this, it turns out, is relevant. As after this HHVM issue is fixed the php errors persist.''
    68
    79So, I stand by my initial patch request.