| 5 | | However, this sort of "glitch" should still not be allowed through core as the point of this particular `!is_scalar()` conditional is to filter out junk that won't pass `rawurlencode()`. And `!is_string()` isn't any slower that `!is_scalar()`--initial benchmarks show it might actually be a tad faster. It's also more specific to this purpose. |
| | 5 | However, this sort of "glitch" should still not be allowed through core as the point of this particular `!is_scalar()` conditional is to filter out junk that won't pass `rawurlencode()`. And `!is_string()` isn't any slower that `!is_scalar()`--initial benchmarks show it might actually be a tad faster. It's also more specific to this purpose. |
| | 6 | |
| | 7 | ''--None of this, it turns out, is relevant. As after this HHVM issue is fixed the php errors persist.'' |