WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 2 of Ticket #37086


Ignore:
Timestamp:
06/13/2016 11:08:12 AM (10 years ago)
Author:
ocean90
Comment:

@xavivars Thanks for your patches. The replacement should only be done for Catalan. Removing the dots can maybe handled by sanitize_title_with_dashes().

Can you make sure that the patches are relative to the root directory? And there should be a unit test for this change in /tests/phpunit/tests/formatting/RemoveAccents.php.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #37086

    • Property Keywords needs-refresh has-patch needs-unit-tests added
    • Property Milestone Awaiting Review → Future Release

  • Ticket #37086 – Description

    initial v2  
    1 Currently, [remove_accents https://core.trac.wordpress.org/browser/tags/4.5.2/src/wp-includes/formatting.php#L1132] converts all characters to an ASCII equivalent so it looks "nice" as a URLs without the need of escaping characters (and, thus, showing % as part of the links).
     1Currently, [https://core.trac.wordpress.org/browser/tags/4.5.2/src/wp-includes/formatting.php#L1132 remove_accents()] converts all characters to an ASCII equivalent so it looks "nice" as a URLs without the need of escaping characters (and, thus, showing % as part of the links).
    22
    33However, the middle dot (U+00B7) is not removed. Middle dot is used in Catalan between two L (like this l·l).