Requests: Proxy settings aren't honoured

[johnbillion]

Requests is not honouring the WP_PROXY_HOST and WP_PROXY_PORT constants when they're defined in wp-config.php. Any HTTP API requests simply bypass the proxy.

[johnbillion]

If you don't have a proxy to hand to test this, then entering dummy data into those constant values should cause the HTTP API request to fail, but it doesn't.

[ocean90]

Looks like WP_HTTP_Proxy is used directly in WP_Http_Curl() and WP_Http_Streams() instead of WP_Http::request() ,where it belongs I suppose, so it can be passed to Requests::request().

@dd32, @rmccue: Looks like this requires some work.

[rmccue]

Use proxy in Requests if available

[rmccue]

Patch added.

@johnbillion If you already have a local setup with this, can you test and verify?

[johnbillion]

37107.diff​ doesn't fix the issue. Requests are still bypassing the proxy.

Inside Requests_Proxy_HTTP::curl_before_send(), $this->proxy has no value at the point where the request is made.

[ocean90]

@johnbillion Can you please test again with ​https://github.com/rmccue/Requests/pull/223 applied?

[johnbillion]

With 37107.diff​ and ​https://github.com/rmccue/Requests/pull/223 both applied, Requests does now honour the proxy.

[rmccue]

Upstream PR is now merged, needs an update in the bundled version.

[ocean90]

In 38053:

HTTP API: Update Requests.

Fixes an issue where you couldn't set a Requests_Proxy_HTTP object as a proxy setting.

See ​https://github.com/rmccue/Requests/pull/223.
See #37107, #33055.

[ocean90]

In 38054:

HTTP API: Pass proxy settings to Requests.

WP_HTTP_Proxy() is used directly in WP_Http_Curl() and WP_Http_Streams(). Since WP_Http::request() doesn't use them anymore we have to move the proxy handling into WP_Http::request() so the proxy data can be passed to Requests::request().

Props rmccue.
See #33055.
Fixes #37107.