WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #37110, comment 171


Ignore:
Timestamp:
08/01/2020 08:48:24 PM (2 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #37110, comment 171

    initial v1  
    11Looking a bit more at 37110-add-dependency.diff, it may introduce a circular dependency (`jquery` depends on `jquery-migragte`, and `jquery-migragte` depends on `jquery`) if a plugin restores the way the `jquery` script-handle used to work in WP 5.4 and earlier. For example the https://github.com/WordPress/wp-jquery-update-test does this with the appropriate settings, see https://github.com/WordPress/wp-jquery-update-test/blob/trunk/class_wp_jquery_update_test.php#L59.
    22
    3 If core has to provide an easy way for plugins and themes to still be able to load jQuery with jQuery Migrate, something like 37110-add-dependency.2.diff will be preferable. Then, once jQuery is updated to 3.x, the temporary script-handle can be removed. This means plugins and themes that still use it at that point will fail to load their scripts (as a dependency will be missing), but will not cause "fatal errors" breaking the rest of js.
     3If core has to provide an easy way for plugins and themes to still be able to load jQuery with jQuery Migrate in WP 5.5, something like 37110-add-dependency.2.diff will be preferable. Then, once jQuery is updated to 3.x, the temporary script-handle can be removed. This means plugins and themes that still use it at that point will fail to load their scripts (as a dependency will be missing), but will not cause "fatal errors" breaking the rest of js.