WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37111 closed enhancement (fixed)

Improve handling of files without extensions

Reported by: joemcgill Owned by: joemcgill
Milestone: 4.5.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

In certain situations uploaded files can result in a blank filename. In those cases we should add a default filename.

Attachments (3)

37111.diff (2.0 KB) - added by joemcgill 3 years ago.
37111.2.diff (2.0 KB) - added by joemcgill 3 years ago.
Fix typos
37111.3.diff (2.0 KB) - added by joemcgill 3 years ago.

Download all attachments as: .zip

Change History (16)

@joemcgill
3 years ago

#1 @joemcgill
3 years ago

  • Owner set to joemcgill
  • Status changed from new to assigned

#2 follow-up: @swissspidy
3 years ago

Would this result in unnamed-file.jpg, unnamed-file-2.jpg, etc.?

#3 in reply to: ↑ 2 @joemcgill
3 years ago

Replying to swissspidy:

Would this result in unnamed-file.jpg, unnamed-file-2.jpg, etc.?

Good question. It will indeed since this function is called from within wp_unique_filename(), where incrementing duplicate file names is handled.

@joemcgill
3 years ago

Fix typos

@joemcgill
3 years ago

#4 @joemcgill
3 years ago

In 37809:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 4.5 branch.

See #37111.

#5 @joemcgill
3 years ago

In 37810:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 4.4 branch.

See #37111.

#6 @joemcgill
3 years ago

In 37814:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 4.3 branch.

See #37111.

#7 @joemcgill
3 years ago

In 37816:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 4.2 branch.

See #37111.

#8 @joemcgill
3 years ago

In 37818:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 4.1 branch.

See #37111.

#9 @joemcgill
3 years ago

In 37819:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 4.0 branch.

See #37111.

#10 @joemcgill
3 years ago

In 37822:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 3.9 branch.

See #37111.

#11 @joemcgill
3 years ago

In 37824:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 3.8 branch.

See #37111.

#12 @joemcgill
3 years ago

In 37825:

Media: Improve handling of extensionless filenames.

Merge of [37756] to the 3.7 branch.

See #37111.

#13 @joemcgill
3 years ago

  • Milestone changed from Awaiting Review to 4.5.3
  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [37756]

Note: See TracTickets for help on using tickets.