![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 10 years ago
Closed 10 years ago
#37126 closed defect (bug) (fixed)
Shiny Updates: plugin updates fail from the update-core.php details modal
| Reported by: | afercia | Owned by: | swissspidy |
|---|---|---|---|
| Priority: | high | Milestone: | 4.6 |
| Component: | Upgrade/Install | Version: | 4.6 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | javascript |
Description
To reproduce, go in update-core.php:
- click the "View version details" link on any available plugin update
- the details modal opens
- click the "Install Update Now" button
- nothing happens, the browser console reports a JS error
On Firefox, the error message is a bit more clear and it says that $message is undefined.
Quickly looking at the updates.js code, maybe when clicking on '#plugin_install_from_iframe' the check for the 'update-core.php' window parent should be reintroduced when returning early before event.preventDefault().
Attachments (1)
Change History (6)
This ticket was mentioned in Slack in #feature-shinyupdates by swissspidy. View the logs.
10 years ago
@
10 years ago
Revert github commit from shiny updates plugin - https://github.com/obenland/shiny-updates/pull/165
Note:
See TracTickets
for help on using tickets.
This bug came into being after the GitHub issue https://github.com/obenland/shiny-updates/issues/153
Since the update-core.php changes are now part of Shiny Updates V3, This button can be made un-shiny again.