WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37127 closed defect (bug) (fixed)

Shiny Updates: Decrement update count for translation updates

Reported by: swissspidy Owned by: swissspidy
Milestone: 4.6 Priority: high
Severity: normal Version: 4.6
Component: Upgrade/Install Keywords: has-patch
Focuses: javascript Cc:
PR Number:

Description

As pointed out by afercia, the update counts do not get correctly decremented when updating translations on wp-admin/update-core.php. That page is not 100% shiny yet, but decrementing should work nonetheless.

https://cldup.com/xvFRJGnLg3.png

This can be easily fixed in wp.updates.decrementCount()

Attachments (1)

37127.diff (1011 bytes) - added by swissspidy 3 years ago.

Download all attachments as: .zip

Change History (7)

#1 @swissspidy
3 years ago

  • Owner set to swissspidy
  • Status changed from new to assigned

#2 @Presskopp
3 years ago

Related: #36773

Last edited 3 years ago by Presskopp (previous) (diff)

This ticket was mentioned in Slack in #feature-shinyupdates by swissspidy. View the logs.


3 years ago

#4 @ocean90
3 years ago

  • Keywords needs-patch added
  • Priority changed from normal to high

There should be at least no error be thrown. Previously only plugins were supported, see https://core.trac.wordpress.org/browser/tags/4.5.3/src/wp-admin/js/updates.js?marks=98-138#L91.

@swissspidy
3 years ago

#5 @swissspidy
3 years ago

  • Keywords has-patch added; needs-patch removed

#6 @swissspidy
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37971:

Update/Install: Correctly decrement the update count after translation updates.

After [37714], an error was unnecessarily being displayed in the JavaScript console when updating translations on wp-admin/update-core.php. Let's not throw an error in these cases.

Props afercia.
Fixes #37127.

Note: See TracTickets for help on using tickets.