WordPress.org

Make WordPress Core

Changes between Initial Version and Version 4 of Ticket #37132


Ignore:
Timestamp:
06/21/2016 07:13:04 AM (5 years ago)
Author:
swissspidy
Comment:

It's worth noting that the minified tinymce.min.js file is directly obtained from upstream, https://www.tinymce.com/.

Besides that, I agree with johnbillion. If the JS output depends on PHP, you should add that part as an inline script instead.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #37132

    • Property Keywords reporter-feedback added
  • Ticket #37132 – Description

    initial v4  
    1 When apache is set to parse .js files for PHP (needed in some cases), it causes timymce.min.js to return a 500 error. This is because one part of the file uses a php open tag "<?":
     1When apache is set to parse .js files for PHP (needed in some cases), it causes `tinymce.min.js` to return a 500 error. This is because one part of the file uses a php open tag `"<?"`:
    22
    3 pi:function(e,t){t?r.push("<?",e," ",s(t),"?>"):r.push("<?",e,"?>"),i&&r.push("\n")}
     3`pi:function(e,t){t?r.push("<?",e," ",s(t),"?>"):r.push("<?",e,"?>"),i&&r.push("\n")}`
    44
    55It would be best if this part of the file was written so that it would not return a 500 error if .js files are parsed for PHP. A simple fix:
    66
    7 pi:function(e,t){t?r.push("<"+"?",e," ",s(t),"?"+">"):r.push("<"+"?",e,"?"+">"),i&&r.push("\n")}
     7`pi:function(e,t){t?r.push("<"+"?",e," ",s(t),"?"+">"):r.push("<"+"?",e,"?"+">"),i&&r.push("\n")}`