WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#37172 closed defect (bug) (wontfix)

Fix class attribute quotation

Reported by: michalzuber's profile michalzuber Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Focuses: administration Cc:

Description

While looking at #32017 found that the class attribute has different quotation then the rest of the code.

Attachments (1)

37172.patch​ (1.4 KB) - added by michalzuber 9 years ago.
Replace ' with "

Download all attachments as: .zip

Change History (3)

#1 @michalzuber
9 years ago

Patch attached. I also replaced some new lines \n with PHP's predefined constant for that which is OS specific (​http://php.net/manual/en/reserved.constants.php#116600)
Cheers from #WCEU

Last edited 9 years ago by michalzuber (previous) (diff)

@michalzuber
9 years ago

Replace ' with "

#2 @pento
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version trunk deleted

Thank you for the patch, @michalzuber!

I'm going to close this ticket as wontfix, for a couple of reasons:

  • Per the ​WordPress Coding Standards, alternating quote style is fine - the more important part is to not use the concatenation operator. Variables should be evaluated in the string.
  • We don't use the PHP_EOL constant in core at all.
Note: See TracTickets for help on using tickets.