WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 5 months ago

Last modified 4 months ago

#37176 closed defect (bug) (duplicate)

A really long title is breaking the layout with the default themes

Reported by: metodiew Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: dev-feedback 2nd-opinion needs-patch bulk-reopened
Focuses: Cc:

Description

While I was working on #36081 I've noticed an issue with all default themes, besides Twenty Twelve and Twenty Sixteen.

I know it's a super edge case and having a title this long probably won't happen, but this is an issue with a quick fix.

We can add word-wrap: break; to the wrapper container, which should fix most of the problems with a really long word.

I'll work on a patch, but in the meanwhile a second opinion, a related ticket or whatever would be useful is more than welcome!

Attachments (7)

twenty-ten.png (534.4 KB) - added by metodiew 3 years ago.
Twenty Ten
twenty-thirteen.png (166.6 KB) - added by metodiew 3 years ago.
Twenty Thirteen
twenty-fourteen.png (134.1 KB) - added by metodiew 3 years ago.
Twenty Fourteen
twenty-fiteen.png (125.9 KB) - added by metodiew 3 years ago.
Twenty Fifteen
twenty-sixteen.png (112.7 KB) - added by metodiew 3 years ago.
Twenty Sixteen - we have no issue here
37176.diff (4.0 KB) - added by metodiew 3 years ago.
37176.2.diff (1.9 KB) - added by metodiew 3 years ago.
Attached an updated version of the patch, created from a clear trunk copy

Download all attachments as: .zip

Change History (19)

@metodiew
3 years ago

Twenty Ten

@metodiew
3 years ago

Twenty Thirteen

@metodiew
3 years ago

Twenty Fourteen

@metodiew
3 years ago

Twenty Fifteen

@metodiew
3 years ago

Twenty Sixteen - we have no issue here

This ticket was mentioned in Slack in #core-themes by metodiew. View the logs.


3 years ago

@metodiew
3 years ago

#2 @metodiew
3 years ago

  • Keywords has-patch dev-feedback 2nd-opinion added

That's the initial version of the patch, but I'm not 100% sure if those general rules are placed properly

@metodiew
3 years ago

Attached an updated version of the patch, created from a clear trunk copy

#3 @SergeyBiryukov
3 years ago

  • Component changed from Themes to Bundled Theme

Related: #25008, #25232, #29971, #36346.

#4 @karmatosed
3 years ago

As chatted about at WCEU contribution day, @metodiew is going to do some work on this and see if he can find a happy medium between devices, browsers and a solution.

#5 @ocean90
3 years ago

  • Version trunk deleted

#6 @karmatosed
3 years ago

  • Keywords needs-patch added; has-patch removed

#7 in reply to: ↑ description @ctienshi
3 years ago

let me work on a patch

#8 follow-up: @metodiew
3 years ago

hey @karmatosed thanks for the quick response!

I searched for other possible solutions and also I've checked the support for word-wrap here http://caniuse.com/#search=word-wrap

Based on my experience this is the best possible solution that works everywhere.

I agree that we have to cover as much as we can, but to be honest I prefer to fix the issue for the vast majority or the users and fix the edge cases later than having this issue with our bundled themes.

@ctienshi have you checked the attached patch 37176.2.diff? Is it working for you?

#9 in reply to: ↑ 8 @ctienshi
3 years ago

@metodiew Yes the patch worked for me. Thanks

This ticket was mentioned in Slack in #core-themes by karmatosed. View the logs.


3 years ago

#13 @SergeyBiryukov
5 months ago

  • Keywords bulk-reopened added
  • Resolution set to duplicate
  • Status changed from new to closed

Hi @metodiew, thanks for the patch! Sorry it took so long for someone to get back to you.

I'm going to close this in favor of #36346 and related tickets, which appear to have more traction:

#46669
Twenty Ten: Long non-breaking text strings can cause horizontal scrolling
#46674
Twenty Eleven: Long non-breaking text strings can cause horizontal scrolling
#46676
Twenty Twelve: Long non-breaking text strings can cause horizontal scrolling
#46695
Twenty Thirteen: Long non-breaking text strings can cause horizontal scrolling
#46696
Twenty Fourteen: Long non-breaking text strings can cause horizontal scrolling
#46697
Twenty Fifteen: Long non-breaking text strings can cause horizontal scrolling
#46700
Twenty Sixteen: Long non-breaking text strings can cause horizontal scrolling
#46703
Twenty Seventeen: Long non-breaking text strings can cause horizontal scrolling
#46704
Twenty Nineteen: Long non-breaking text strings can cause horizontal scrolling


If there's something here not covered in those tickets, please feel free to reopen.

#14 @metodiew
5 months ago

Thanks for the update, @SergeyBiryukov! Let me know if there is anything I can help with https://core.trac.wordpress.org/ticket/36346, so we can move forward! :)

Note: See TracTickets for help on using tickets.