WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #37181, comment 43


Ignore:
Timestamp:
12/20/2017 02:13:42 PM (7 years ago)
Author:
spacedmonkey
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #37181, comment 43

    initial v1  
    33>
    44> * We're switching from `site-options` to `site_meta` as the cache group, but still using `site-options` for a handful of other things—`current_network`, `networks_have_paths`, etc... This is probably okay because we weren't ever storing those "options" in the DB.
    5 I think we need to support the `site-options` cache group forever more. It is ued else where in core and I am personally use it for some plugin. I see more harm in leaving it.
     5I think we need to support the `site-options` cache group forever more. It is used else where in core and I am personally use it for some plugin. I see no harm in leaving it.
    66> * We'll want to make sure once this is in that external object cache drop-ins are aware/updated with the new global cache group.
    77Most modern object cache drops implement the `wp_cache_add_global_groups`, which should do this for us. Examples, can found, [https://github.com/humanmade/memcache-object-cache/blob/master/object-cache.php#L128 here], [https://github.com/Automattic/wp-memcached/blob/master/object-cache.php#L101 here], [https://github.com/tollmanz/wordpress-pecl-memcached-object-cache/blob/master/object-cache.php#L744 here], [https://github.com/stuttter/wp-spider-cache/blob/master/wp-spider-cache/includes/functions.php#L827 here] and [https://github.com/pantheon-systems/wp-redis/blob/master/object-cache.php#L212 here]. These are the largest plugins that I know of. Older ones may not have it implement it, but that will break other things and is not a core problem.