WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 5 months ago

#37185 assigned defect (bug)

wp_print_styles() doesn't call "wp_print_styles" action when "$handles" argument passed

Reported by: evgenniy Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.3.1
Component: Script Loader Keywords: needs-unit-tests has-patch needs-refresh
Focuses: Cc:
PR Number:

Description

In wp_print_styles(), there is "wp_print_styles" action calls when function is used with optional "$handles" argument.

if () statement should be deleted ( like wp_print_scripts() ).

Unit tests are passed.

Attachments (1)

functions.wp-styles.diff​ (385 bytes) - added by evgenniy 3 years ago.
Patch

Download all attachments as: .zip

Change History (8)

@evgenniy
3 years ago

Patch

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Script Loader
  • Milestone changed from Awaiting Review to 4.6

#2 follow-up: @stephenharris
3 years ago

  • Keywords needs-unit-tests has-patch added

@evgenniy are you able to add a unit test for this?

#3 @rachelbaker
3 years ago

  • Owner set to rachelbaker
  • Status changed from new to accepted

#4 @SergeyBiryukov
3 years ago

  • Version changed from trunk to 3.3.1

Introduced in [19649].

#5 in reply to: ↑ 2 @evgenniy
3 years ago

Replying to stephenharris:

@evgenniy are you able to add a unit test for this?

Yes, I can add unit test for wp_print_styles() function.

#6 @rachelbaker
3 years ago

  • Keywords needs-refresh added
  • Owner rachelbaker deleted
  • Status changed from accepted to assigned

@evgenniy It would also be helpful if you could generate the patch from the root directory. Looks like functions.wp-styles.diff​ was generated from within the wp-includes directory.

#7 @rachelbaker
3 years ago

  • Milestone changed from 4.6 to Future Release

Punting out of 4.6 pending unit tests and a refreshed patch

Note: See TracTickets for help on using tickets.