Opened 9 years ago
Closed 8 days ago
#37185 closed defect (bug) (wontfix)
wp_print_styles() doesn't call "wp_print_styles" action when "$handles" argument passed
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.3.1 |
Component: | Script Loader | Keywords: | needs-unit-tests has-patch needs-refresh |
Focuses: | Cc: |
Description
In wp_print_styles()
, there is "wp_print_styles" action calls when function is used with optional "$handles" argument.
if ()
statement should be deleted ( like wp_print_scripts()
).
Unit tests are passed.
Attachments (1)
Change History (9)
#1
@
9 years ago
- Component changed from General to Script Loader
- Milestone changed from Awaiting Review to 4.6
#2
follow-up:
↓ 5
@
9 years ago
- Keywords needs-unit-tests has-patch added
@evgenniy are you able to add a unit test for this?
#5
in reply to:
↑ 2
@
9 years ago
Replying to stephenharris:
@evgenniy are you able to add a unit test for this?
Yes, I can add unit test for wp_print_styles() function.
#6
@
9 years ago
- Keywords needs-refresh added
- Owner rachelbaker deleted
- Status changed from accepted to assigned
@evgenniy It would also be helpful if you could generate the patch from the root directory. Looks like functions.wp-styles.diff was generated from within the wp-includes directory.
#7
@
9 years ago
- Milestone changed from 4.6 to Future Release
Punting out of 4.6 pending unit tests and a refreshed patch
#8
@
8 days ago
- Resolution set to wontfix
- Status changed from assigned to closed
The inclusion of the if
was done intentionally in [19649] to fix #19510. Removing the if
will cause all kinds of back-compat breakage now.
If an action is needed whenever wp_print_styles()
is called regardless of whether the $handles
arg is passed, then we'll need a new action to trigger separately.
Patch