Opened 10 years ago
Closed 15 months ago
#37185 closed defect (bug) (wontfix)
wp_print_styles() doesn't call "wp_print_styles" action when "$handles" argument passed
| Reported by: | evgenniy | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Script Loader | Version: | 3.3.1 |
| Severity: | normal | Keywords: | needs-unit-tests has-patch needs-refresh |
| Cc: | Focuses: |
Description
In wp_print_styles(), there is "wp_print_styles" action calls when function is used with optional "$handles" argument.
if () statement should be deleted ( like wp_print_scripts() ).
Unit tests are passed.
Attachments (1)
Change History (9)
#2
follow-up:
↓ 5
@
10 years ago
- Keywords needs-unit-tests has-patch added
@evgenniy are you able to add a unit test for this?
#5
in reply to: ↑ 2
@
10 years ago
Replying to stephenharris:
@evgenniy are you able to add a unit test for this?
Yes, I can add unit test for wp_print_styles() function.
#6
@
10 years ago
- Keywords needs-refresh added
- Owner removed
- Status accepted → assigned
@evgenniy It would also be helpful if you could generate the patch from the root directory. Looks like functions.wp-styles.diff was generated from within the wp-includes directory.
#7
@
10 years ago
- Milestone 4.6 → Future Release
Punting out of 4.6 pending unit tests and a refreshed patch
#8
@
15 months ago
- Resolution → wontfix
- Status assigned → closed
The inclusion of the if was done intentionally in [19649] to fix #19510. Removing the if will cause all kinds of back-compat breakage now.
If an action is needed whenever wp_print_styles() is called regardless of whether the $handles arg is passed, then we'll need a new action to trigger separately.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Patch