Incorrect docs for second param of `wp_nav_menu_item_(taxonomy|post_type)_meta_box()`

[ocean90]

This is about wp_nav_menu_item_post_type_meta_box() and wp_nav_menu_item_taxonomy_meta_box().

The DocBlock of both both functions declare the second param as string and post type/taxonomy object, but it's an array with four keys:

• https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/template.php?annotate=blame&marks=974&rev=37737#L966
• https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/ajax-actions.php?annotate=blame&marks=1472-1477&rev=37779#L1443.

[ocean90]

$posttype is also passed to "nav_menu_items_{$post_type_name}_recent" which should be $posttype[args] or the result of get_post_type_object() like it's done for "nav_menu_items_{$post_type_name}".

[mehulkaklotar]

PHPDoc for both functions changed

[swissspidy]

Thanks for the patch @mehulkaklotar, but as stated in the ticket description those aren't objects but arrays instead. So not only the type is wrong, but also the description.

The arrays would need to be documented according to our inline documentation standards: ​https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#1-1-parameters-that-are-arrays

[mehulkaklotar]

changed phpdoc as per handbook instructions

[DrewAPicture]

Assigning to mark the good-first-bug as "claimed".

See 37211.2.diff​

[ocean90]

@mehulkaklotar Thanks for your patch. Some feedback:

• Each line should end with a period.
• "A id" should be "An ID".
• $args is not an array, it's an object for wp_nav_menu_item_taxonomy_meta_box() and WP_Post_Type for wp_nav_menu_item_post_type_meta_box().
• "An array of post type arguments" should be replaced with something else. I think we can use something similar to the one we're using for $callback_args from ​https://developer.wordpress.org/reference/functions/add_meta_box/.

[SergeyBiryukov]

In 38127:

Docs: Correct and expand the docs for the $post_type argument of wp_nav_menu_item_post_type_meta_box().

Props mehulkaklotar for initial patch.
See #37211.

[SergeyBiryukov]

In 38128:

Docs: Correct and expand the docs for the $taxonomy argument of wp_nav_menu_item_taxonomy_meta_box().

Props mehulkaklotar for initial patch.
See #37211.

[SergeyBiryukov]

In 38129:

Menus: In wp_nav_menu_item_post_type_meta_box():

• Rename the $post_type parameter to $box for clarity and consistency with other meta box functions.
• Make the docs more consistent with post_format_meta_box() and other meta box functions.
• Correct type and description for the third argument of nav_menu_items_{$post_type_name}_recent filter.

See #37211.

[SergeyBiryukov]

In 38130:

Menus: In wp_nav_menu_item_taxonomy_meta_box():

• Rename the $taxonomy parameter to $box for clarity and consistency with other meta box functions.
• Make the docs more consistent with post_categories_meta_box() and other meta box functions.

See #37211.

[SergeyBiryukov]

In 38131:

Docs: In meta box functions, clarify that "Meta box ID" refers to the id attribute of the meta box and not a numeric ID.

Fixes #37211.

[ocean90]

Thanks for the cleanup.

[SergeyBiryukov]

In 38142:

Docs: Update the description of the $box argument of wp_nav_menu_item_taxonomy_meta_box() for consistency with [38129].

Missed in [38130].

See #37211.