PHP 7 compatibilty issues in twentythirteen and twentyfourteen

[xknown]

While running the ​php7cc tool, it reported two incompatibilities for the above mentioned themes.

​PHP 7 changes the behavior of the foreach loop. It doesn't longer modify the internal array pointer, thus using it with current/reset/etc doesn't produce the expected results.

You can see the different results for PHP 5.x vs PHP 7.x ​https://3v4l.org/oQiI9

The problematic lines are in the following methods

• twentythirteen_the_attached_image - #
• twentyfourteen_the_attached_image - #

[xknown]

Patch for twentythirteen

[xknown]

Patch for twentyfourteen

[xknown]

You can see the output of the proposed patches in ​https://3v4l.org/2SPQf

cc @davidakennedy @karmatosed

[davidakennedy]

This would be good to do, and the patch is similar to changes made to dozens of themes on WordPress.com with no issues.

[karmatosed]

In 38026:

PHP 7 compatibility issues fixed in Twenty Thirteen and Twenty Fourteen
Props xknown
Fixes #37227
--This Line, and those below, will be ignored--

M themes/twentyfourteen/functions.php
M themes/twentythirteen/functions.php