WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#37254 closed defect (bug) (fixed)

$this->request duplication in WP_Term_Query

Reported by: birgire Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.6
Component: Taxonomy Keywords: has-patch
Focuses: Cc:
PR Number:

Description (last modified by swissspidy)

This part of WP_Term_Query looks like a duplication:

$this->request = $this->request = "{$this->sql_clauses['select']} ... etc

I guess this structure originates from the WP_Query:

$this->request = $old_request = "SELECT ... etc";

Attachments (1)

class-wp-term-query.diff (942 bytes) - added by birgire 4 years ago.

Download all attachments as: .zip

Change History (7)

#1 @birgire
4 years ago

  • Keywords has-patch added

#2 @birgire
4 years ago

ps: I meant of course WP_Term_Query, not WP_Tax_Query, but I can't modify the original ticket ;-)

#3 @swissspidy
4 years ago

  • Description modified (diff)
  • Summary changed from $this->request duplication in WP_Tax_Query to $this->request duplication in WP_Term_Query

#4 @birgire
4 years ago

thanks @swissspidy

#5 @ocean90
4 years ago

  • Component changed from Query to Taxonomy
  • Milestone changed from Awaiting Review to 4.6

#6 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 38020:

Taxonomy: Remove an unnecessary double assignment in WP_Term_Query::get_terms().

Props birgire.
Fixes #37254.

Note: See TracTickets for help on using tickets.