Shiny Updates: Cancelling the filesystem credentials prevents updating themes unless you reload

[DavidAnderson]

Running on the latest nightly: 4.6-beta1-37961

Reproducible: every time

Steps to reproduce:

1) Set up WordPress, and set permissions to that the 'filesystem credentials' dialog will be required when performing theme updates.

2) Go to /wp-admin/themes.php

3) Click on "Update now". The filesystem credentials dialog should open. "Update now" will turn to "Updating..."

4) Close the filesystem credentials dialog. "Updating..." will return to "Update now".

5) Click again on "Update now".

Result: nothing happens.
Excepted result: filesystem credentials dialog should open again. You can only get it back by reloading the page.

Looking at the code, it seems that the initial click cancels all listeners with .off() - and they are never registered again.

[ocean90]

Confirmed, doesn't happen for plugins.

[swissspidy]

I don't know why this was added, but I didn't encounter any problems after removing the this.$el.off( 'click', '.update-message' ); line.

[swissspidy]

@DavidAnderson Can you confirm whether 37285.diff​ solves the issue? Thanks!

[DavidAnderson]

@swissspidy : I think so, but I'm puzzled by a problem that turned up in testing of our plugin, and then seemed to just vanish without any obvious reason. So, I'm going to test it further tomorrow and get back to you.

[DavidAnderson]

Further testing has turned up no problems. All seems well.

[swissspidy]

In 38019:

Upgrade/Install: Do not remove event handlers when trying to update a theme.

Previously, when clicking "Update now" the callbacks were erroneously removed. This prevented opening the filesystem credentials modal for a second time.

Fixes #37285.