WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#37286 closed defect (bug) (fixed)

Site Icon: Preview when cropping an image is broken in RTL

Reported by: ocean90 Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch
Focuses: rtl Cc:

Description

  • When cropping an image in the media modal the app icon preview doesn't get always updated. The image wrapper needs a direction: ltr wrapper.
  • Same for the favicon, but this is more fun. It updates the wrong preview. Instead of updating the one in the media modal it updates the one in the customizer panel because both are using the same ID.

Attachments (1)

37286.patch (501 bytes) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (4)

@ocean90
4 years ago

#1 @ocean90
4 years ago

  • Version changed from 4.4 to 4.3

#2 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to 4.6

#3 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 37964:

Customize: Fix site icon preview in RTL.

  • Set the direction of previews to LTR.
  • Remove the ID attribute from the favicon preview in the customizer panel. The preview in the media modal uses the same ID which prevented updating the correct favicon preview.

Fixes #37286.

Note: See TracTickets for help on using tickets.