PHP 7.1.0: Tests_Query_IsTerm::test_cat_uncat_action_tax() is failing

[ocean90]

Tested with PHP 7.1.0alpha3 (cli) (built: Jul 6 2016 11:50:33).

See ​https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/142322444#L387-L396 and

1) Tests_Query_IsTerm::test_cat_uncat_action_tax
Parameter 1 to Tests_Query_IsTerm::_cat_uncat_action_tax() expected to be a reference, value given

/src/wp-includes/plugin.php:600
/src/wp-includes/query.php:2503
/src/wp-includes/query.php:4050
/src/wp-includes/class-wp.php:609
/src/wp-includes/class-wp.php:727
/tests/phpunit/includes/testcase.php:462
/tests/phpunit/tests/query/isTerm.php:123

I haven't found something in the changelog (​https://github.com/php/php-src/blob/PHP-7.1.0/NEWS) which could cause this behaviour. I only know that removing the filter for pre_get_posts makes the test passing.

[netweb]

I had a quick search and found: ​https://www.itnota.com/fixing-php7-compatibility-issue-w3-total-cache/

• Pull request and test in ​https://github.com/aaronjorbin/develop.wordpress/pull/12
• Travis CI PHP 7 nightly job: ​https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/142736292

Patch 37295.diff​ pass's PHP nightly job

I also couldn't find anything in ​https://github.com/php/php-src/blob/PHP-7.1.0/NEWS that matched up /shrug

[ocean90]

There is also Tests_Query_IsTerm::pre_get_posts_tax_category_tax_query() and Tests_Query_Conditionals::pre_get_posts_with_tax_query, why is there no error for them?

[netweb]

I've no idea ¯\_(ツ)_/¯

[SergeyBiryukov]

Replying to netweb:

I also couldn't find anything in ​https://github.com/php/php-src/blob/PHP-7.1.0/NEWS that matched up

​https://bugs.php.net/bug.php?id=72508 seems to be related.

[mensmaximus]

Replying to SergeyBiryukov:

​https://bugs.php.net/bug.php?id=72508 seems to be related.

But that one is already patched: ​http://git.php.net/?p=php-src.git;a=commit;h=ce7e180a04009e821c87e7ae2b704294a2a97c03

[ocean90]

Upstream ticket: ​https://bugs.php.net/bug.php?id=72598

[ocean90]

This is going to be fun...

From the ticket:

PHP-7.1 doesn't allow modification of $this through references on purpose.
See ​https://wiki.php.net/rfc/this_var#disable_ability_to_re-assign_this_indirectly_through_reference

The simplest workaround is replacing $this with another variable.

- do_action_ref_array( 'pre_get_posts', [ &$this ] );
+ $obj = $this;
+ do_action_ref_array( 'pre_get_posts', [ &$obj ] );

[netweb]

Replying to ocean90:

From the ticket:

PHP-7.1 doesn't allow modification of $this through references on purpose.
See ​https://wiki.php.net/rfc/this_var#disable_ability_to_re-assign_this_indirectly_through_reference

The simplest workaround is replacing $this with another variable.

- do_action_ref_array( 'pre_get_posts', [ &$this ] );
+ $obj = $this;
+ do_action_ref_array( 'pre_get_posts', [ &$obj ] );

A new reply to that reply:

... that's a workaround, but it's only a workaround for the bug… the bug needs to be fixed somehow though before 7.1.0. I don't find this broken behavior acceptable to be shipped in the release.

Thanks for creating the PHP ticket @ocean90, so at least there is now some progress and more fun to come for sure

[ocean90]

PHP 7.1.0 beta 2 was released a few days ago. phpunit.output​ is the output for

$ php -v
PHP 7.1.0beta2 (cli) (built: Aug  9 2016 22:03:47) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.1.0-dev, Copyright (c) 1998-2016 Zend Technologies
    with Xdebug v2.4.0, Copyright (c) 2002-2016, by Derick Rethans
$ phpunit --version
PHPUnit 5.5.0 by Sebastian Bergmann and contributors.

It's not only one failing test anymore:

Tests: 6363, Assertions: 20176, Errors: 42, Failures: 22, Skipped: 73.

[ocean90]

A fix for this was committed the other day: ​https://github.com/php/php-src/commit/906456c4106ac74da0688b2481e91e27de3b176b

The warning will remain but the call is no longer aborted.

Related: #37772

[ocean90]

Fixed in [38571].