Deprecate get_blogaddress_by_id function

[spacedmonkey]

The get_blogaddress_by_id function is pretty old and should be replaced with get_home_url, as this is filtered.

[thomaswm]

You cannot replace get_blogaddress_by_id with get_home_url in install_blog(), because the home option hasn't been defined yet at that point. It is set in line 1360 in ms-functions.php.

So, in install_blog(), you'll have to do something like

$site = get_site( $blog_id );
$url = 'http://' . $site->domain . $site->path;

to get the value of $url.

[jeremyfelt]

Noting #26855 in here as well. Let's see if we can deprecate this early. :)

[jorbin]

Early is coming to a an end. (whatever early means). @jeremyfelt - Think this can go in, or do you need to do #26855 first?

[jeremyfelt]

I spent some time with 37297.diff​ the other day and ran into some uncertainty.

As @thomaswm mentioned, get_home_url() is not appropriate solution for install_blog(). get_blogaddress_by_id() attempts to use the home option to determine the URL's scheme, but it will always be empty at this point. We then know it will be HTTP combined with the site's domain and path.

It does seem to be the right option for wpmu_welcome_notification(). I'd like this to be tested more though.

The use in wp-activate.php has already been removed via #26855.

[flixos90]

This needs further thought and should be tested earlier in a release cycle. Let's reconsider it in one of the next releases.

…me_url()

Trac ticket: https://core.trac.wordpress.org/ticket/37297

[spacedmonkey]

From the looks of it, this function is used a little on repo. ​https://wpdirectory.net/search/01JZ3XSV5RBHA3ZCSS9C2QDQ04.

We should consider if this needs to be deprecated.

Added needs refresh, as the patch is 9 years old. This will have to be committed / approved by someone else, as I am the original patch creator.

[jorbin]

Doing a bit of gardening and as this isn't actually ready for commit, removing that especially in light of comment 6