Allowing use of single quotes for shortcode empty value attributes

[enrico.sorcinelli]

Recently I created a shortcode allowing empty value attributes.

An user added an empty attribute by surrounding it with single quotes, for example:

[my_shortcode 'foo']Lorem ipsum...[/my_shortcode]

I was surprised that the returned attribute still contains single quotes (for the empty value attributes, the double quotes are stripped instead).

Even if, of course, this is not a bug, I made a patch allowing also using single quotes for shortcode empty value attributes.

Regards

[enrico.sorcinelli]

Updated

[enrico.sorcinelli]

Hi,

I just sent the updated path for current trunk

Regards

[swissspidy]

Would be great to have the tests from #32172 added here if possible.

[swissspidy]

#32172 was marked as a duplicate.

[enrico.sorcinelli]

Hi @swissspidy, I just updated phpunit tests with those of #32172. I also added a more complete qunit test with mxed attributes.

[swissspidy]

I feel like this needs to soak in trunk for some time before going into a release.

Some more eyes on the patch would be helpful.

[enrico.sorcinelli]

The updated patch for current trunk

[enrico.sorcinelli]

I just sent the updated patch for current trunk.

[enrico.sorcinelli]

I just updated the patch to trunk

[SergeyBiryukov]

In 41026:

Shortcodes: Allow using single quotes for empty value attributes.

Props enrico.sorcinelli.
Fixes #37304.

[georgestephanis]

On the off chance that this causes unit test failures for any other plugins, here's how we resolved it in Jetpack: ​https://github.com/Automattic/jetpack/pull/7473/files props @kraftbj