WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 months ago

#37310 new enhancement

To get Term Metadata in $term->meta_key

Reported by: minkapi Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords: needs-patch
Focuses: Cc:

Description

Like postmeta and usermeta, I'd like to get Term Metadata as a property of a term object.
Would you confirm the attached patch file?

Thank you.

Attachments (1)

class-wp-term.php.diff (494 bytes) - added by minkapi 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 @sc0ttkclark
4 years ago

Sounds good to me, this makes sense for feature parity with Posts / Users since they have the same. Terms now have meta, so it should be good to continue that standard.

#2 @desrosj
3 months ago

  • Keywords needs-patch added
  • Milestone set to Future Release

@minkapi Thanks for the patch! Sorry that this one fell through the cracks.

The patch needs to be refreshed against trunk. Are you able to refresh? I haven't dug in too deep yet, but it feels like there may be other changes required.

This seems OK to add, but I'd love to get some more thoughts on this change. @boonebgorges do you have any thoughts?

#3 @boonebgorges
3 months ago

Looks like #40047 is a duplicate. I left my thoughts about this on that ticket: https://core.trac.wordpress.org/ticket/40047#comment:3 Short version is that I don't like the "magic" aspect of this feature. But if others feel strongly that it should be carried over from WP_Post, it's probably fine.

Note: See TracTickets for help on using tickets.