WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#37320 closed defect (bug) (duplicate)

Changed css classes and structure in 4.6 beta

Reported by: programmin Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6
Component: Editor Keywords:
Focuses: ui, javascript Cc:

Description

Looks like there is no longer any reference to a class="wpview-wrap" element in the wp editor wp-views system:

grep -R "wpview-wrap" ./wp-admin

grep -R "wpview-wrap" ./wp-includes/

Same with class="wpview-overlay", also class="wpview-body", no longer referenced anymore, and it seems the structure of these has changed quite a bit from 4.5.

Similarly a class=wpview, not class=wpview-wrap, is the element with the shortcode data-wpview-text, the structure in general has changed.

If this is on purpose, and is part of compatibility work with TinyMCE, there should be a note for developers styling these views in editor, or making manual changes to show the html of wpview-wrap and similar that won't have the expected effect in 4.6.

Change History (3)

#1 @chriscct7
4 years ago

This is on purpose. See #36434

This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.


4 years ago

#3 @iseulde
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Thanks for the ticket! Let's close this in favour of #36434, which is still open? There's a patch there as well.

Note: See TracTickets for help on using tickets.