Pass all attributes in wp_video_shortcode_class, wp_audio_shortcode_class filters

[sakibmoon]

Take a look at the following line of code: https://core.trac.wordpress.org/browser/tags/4.5.3/src/wp-includes/media.php#L2502

$atts['class'] = apply_filters( 'wp_video_shortcode_class', $atts['class'] );

Using this filter we can add/remove class to video container. But I need facility where I can add custom class based on other attribute like video src.

Can we pass all the attributes instead of just the existing classes?

[desrosj]

Hi @sakibmoon! This is a good request. Adding a second parameter to the filter where $atts is passed would be fine. Are you interested in supplying a patch?

[sathyapulse]

Hello @desrosj,

I have prepared the patch for adding the additional attributes parameter to the filter. Could you please check it?

https://core.trac.wordpress.org/attachment/ticket/37329/37329.diff

[SergeyBiryukov]

The same should be done for wp_audio_shortcode_class for consistency.

[sathyapulse]

@desrosj @SergeyBiryukov I have created a new patch file which includes both the Audio and Video shortcode filter changes.

[desrosj]

Assigning the ticket to mark the good-first-bug as "claimed".

@sathyapulse This looks good to me and is a good addition. Marking commit so a committer can check it out.

[SergeyBiryukov]

In 41234:

Media: Pass shortcode attributes to wp_audio_shortcode_class and wp_video_shortcode_class filters.

Props sathyapulse.
Fixes #37329.