Make WordPress Core

Opened 10 years ago

Closed 4 years ago

#37341 closed defect (bug) (worksforme)

Improvements to the list-table.css (breaks the plugin info popup)

Reported by: tivnet's profile tivnet Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.5.3
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

The problem appears in the "View Details" popup with custom updater scripts when the information sections are retrieved from a 3rd party server, not from the WP-org.

For example, when plugins use WooCommerce API Manager, the sections are regular pages and they might have any markup, including headings and images.

Fix 1.
In list-tables.css:

.plugin-install-php h2 {
   clear: both;
}

forces the H2 line jumping down, after the .fyi DIV at the right.

Fix 2.
Images must not go wider than their container.

A possible fix would be adding the following rules to the list-table.css:

#section-holder .section h2 {
	clear: none;
}

#section-holder .section img {
	max-width: 100%
}

Attachments (1)

list-table-css-problems.jpg (108.0 KB) - added by tivnet 10 years ago.
Screenshot demonstrating the problem

Download all attachments as: .zip

Change History (4)

@tivnet
10 years ago

Screenshot demonstrating the problem

#1 follow-up: @DJosephDesign
6 years ago

I have this issue, too, and it seems to be the clear: both for .wrap, possibly being loaded by jQuery UI CSS.

#2 in reply to: ↑ 1 @SergeyBiryukov
6 years ago

Replying to DJosephDesign:

I have this issue, too, and it seems to be the clear: both for .wrap, possibly being loaded by jQuery UI CSS.

Welcome to WordPress Trac! The issue with clear: both for .wrap is fixed in #47561 and will be shipped with WordPress 5.2.3, planned for September 4: https://make.wordpress.org/core/2019/08/22/wordpress-5-2-3-rc-1/.

#3 @desrosj
4 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

I've done some testing with a few plugins that serve updates from locations other than WP.org and I'm unable to reproduce this, so I'm going to close this out.

If someone is still able to reproduce the issue on the latest version of WordPress (currently 6.0), feel free to reopen with more detailed steps to reproduce.

Note: See TracTickets for help on using tickets.