wp_get_attachment_link() outputs nothing if the attachment post has no title

[henry.wright]

wp_get_attachment_link() fails to output if the attachment post doesn't have a title.

This doesn't apply to image attachments, but it does apply to PDFs etc.

[Jonnyauk]

Confirmed - I've replicated this issue with a non-image file (PDF) with no post title where wp_get_attachment_link() doesn't return link, but it functions correctly with a non-titled image file.

It doe work correctly (non image, no title) if you set the $title parameter - but this should not be required.

[Jonnyauk]

Adds additional check if no title set on non-image attachment, and sets filename as fallback

[Jonnyauk]

Correct file path reference

[SergeyBiryukov]

37343-02.patch​ looks reversed. Also, please create patches from the root directory of the repository.

[Jonnyauk]

Updated patch file in correct format (trunk dev version)

[henry.wright]

@Jonnyauk what are your thoughts on using the attachment's file name instead of the guid? Patch incoming...

[Jonnyauk]

@henry.wright - nice - looks a-little neater as a fallback, I've submitted a new patch (37343-05.patch) which retains the original title, which should be used if available.

[henry.wright]

Looks good to me! 😃

[wonderboymusic]

In 38295:

Media: wp_get_attachment_link() fails to output text for non-images if the attachment post doesn't have a title and $text (argument #5) was not passed to the func. In this case, use the filename.

Props Jonnyauk, henry.wright.
Fixes #37343.