![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#37346 closed defect (bug) (fixed)
In wp-mail.php file there is one "dmonths" array variable which is never used
| Reported by: | vishalkakadiya | Owned by: | ocean90 |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.6 |
| Component: | Version: | 4.4 | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
In wp-mail.php there are unused $dmonths = array('Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'); array variable which define in loop which is never used in that file or any other wordpress core files.
I think this should be removed.
Attachments (3)
Change History (10)
#2
@
10 years ago
- Summary wp-mail.php file there are "dmonths" array variable which is not used → In wp-mail.php file there are "dmonths" array variable which is not used
#3
@
10 years ago
- Summary In wp-mail.php file there are "dmonths" array variable which is not used → In wp-mail.php file there is one "dmonths" array variable which is never used
#4
@
10 years ago
- Component General → Mail
- Keywords needs-refresh added
Hi @vishalkakadiya, thanks for the ticket!
Could you submit a patch without all the whitespace fixes? Large formatting cleanups are generally discouraged, see https://make.wordpress.org/core/2011/03/23/code-refactoring/.
#5
@
10 years ago
Hi @SergeyBiryukov,
I attach new "37346_1.patch" file with new patch as you ask without white space fixes. Please check and let me know if anything else required.
Thanks.
Note:
See TracTickets
for help on using tickets.
And also i found Formatting issues, coding standard is not as per WordPress Coding Standard. So I fixed also that.