WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 2 years ago

#37354 closed feature request (worksforme)

cast-sender.js bug workaround for Youtube embed in Chrome

Reported by: brgweb Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Embeds Keywords: close
Focuses: Cc:

Description

There is an open issue marked as "wontfix" by Google with youtube embed: https://code.google.com/p/google-cast-sdk/issues/detail?id=309

When you load it in Chrome it tries to find Chromecast extension. If you don't have it active, it will trigger a js error that breaks all js codes after it.

Some people say that the fix in our side would be loading Youtube JS as the last script in row. But I think that the best answer that I found was to change the url (http://stackoverflow.com/a/32657793/3851035) when it's Chrome.

I could not find where is it in the core to test these. If anyone can point me the right direction I can work in a diff.

Change History (2)

#1 @swissspidy
5 years ago

  • Keywords close added
  • Version 4.5 deleted

I've noticed this error message on other sites as well, but it's clearly a fault in Google Chrome, and I don't think we should "fix" our code for them.

IIRC they're going to make the Chromecast extension obsolete anyway by integrating this directly into Chrome.

#2 @swissspidy
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

I don't think this is an issue anymore nowadays.

Note: See TracTickets for help on using tickets.