WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#37356 closed defect (bug) (fixed)

Add checkComment tests to the comment group

Reported by: rachelbaker Owned by: rachelbaker
Priority: normal Milestone: 4.6
Component: Comments Version: 4.2
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

In [32519] tests for the check_comment() function were added, but these tests do not run as part of the comment group.

The source:trunk/tests/phpunit/tests/comment/checkComment.php​ file needs the following comment before the classname:

/**
 * @group comment
 */

Introduced in #31108.

Attachments (1)

37356.patch​ (481 bytes ) - added by gma992 10 years ago.

Download all attachments as: .zip

Change History (5)

@gma992
10 years ago

#1 @gma992
10 years ago

  • Keywords has-patch added; needs-patch removed

#2 @rachelbaker
10 years ago

  • Keywords commit added; good-first-bug removed
  • Milestone Future Release → 4.6

#3 @rachelbaker
10 years ago

  • Owner set to rachelbaker
  • Resolution → fixed
  • Status new → closed

In 38114:

Tests: Include the check_comment function tests in the comment group.

Adds @group comment notation to the Tests_Comment_CheckComment class. Introduced in [32519].

Props gma992.
Fixes #37356.

#4 @rachelbaker
10 years ago

@gma992 Thanks for the patch!

Note: See TracTickets for help on using tickets.