WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#37358 closed enhancement (fixed)

Don't display errors during installation

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-screenshots has-patch
Focuses: Cc:

Description

If a PHP warning occurs during the installation steps (for example if the HTTP request to the Translation API fails), the error message makes for a wonderfully offputting experience for someone who may be installing WordPress for the first time.

Let's not display errors during installation.

Attachments (2)

Screen Shot 2016-07-13 at 20.22.55.png (145.2 KB) - added by johnbillion 4 years ago.
37358.patch (693 bytes) - added by johnbillion 4 years ago.

Download all attachments as: .zip

Change History (7)

#1 @johnbillion
4 years ago

  • Keywords has-screenshots added

@johnbillion
4 years ago

#2 @johnbillion
4 years ago

  • Keywords has-patch added; needs-patch removed

Patch to suppress the display of errors during installation.

#3 @johnbillion
4 years ago

  • Milestone changed from Future Release to 4.7

#4 @johnbillion
4 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 38423:

Upgrade/Install: Don't display PHP errors during installation.

If a user is installing WordPress for the first time and has set WP_DEBUG to true, a PHP error during installation makes for a visually jarring experience.

Fixes #37358

#5 @SergeyBiryukov
4 years ago

FWIW, I'm not sure I agree with this change.

If someone has explicitly set WP_DEBUG to true, they should see the errors (except those that break AJAX, REST API, or XML-RPC requests). That includes the installation process.

Otherwise, the list of languages is not loaded, but there's no evidence that something's wrong.

Note: See TracTickets for help on using tickets.