Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #37368, comment 6


Ignore:
Timestamp:
08/16/2016 09:07:48 AM (5 years ago)
Author:
deeptiboddapati
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #37368, comment 6

    initial v1  
    11
    2 I looked into this and it ended up being a lot bigger than it first seemed.
     2I looked into this and tested out the patch. I definitely recreated the bug and the patch seemingly fixes it. But when I dug deeper it ended up being a lot bigger than it first seemed.
    33
    44So I looked at 3 functions get_object_taxonomies, get_attachment_taxonomies, get_post_taxonomies.
     
    88get_object_taxonomies() and get_attachment_taxonomies()call each other to evaluate WP_Post objects that are attachments. But get_attachment_taxonomies() just passes it back to get_object_taxonomies() after doing a lot of unneeded text parsing.
    99
    10 This circular dependency should be removed because a lot of other functions depend on get_object_taxonomies().
     10This circular dependency should be removed because a lot of other functions depend on get_object_taxonomies(). But the patch suggested doesn't remove it so while I think it fixes it, I think for the long run we should go another direction.
     11
     12It also doesn't address any of the issues I found below. I don't know if we are supposed to address this here or if I should open bug reports for each of the things I found below.
    1113
    1214I tested the functions and I found issues with each of the functions and I have questions about how to approach fixing them.