Changes between Initial Version and Version 1 of Ticket #37368, comment 6
- Timestamp:
- 08/16/2016 09:07:48 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #37368, comment 6
initial v1 1 1 2 I looked into this and it ended up being a lot bigger than it first seemed.2 I looked into this and tested out the patch. I definitely recreated the bug and the patch seemingly fixes it. But when I dug deeper it ended up being a lot bigger than it first seemed. 3 3 4 4 So I looked at 3 functions get_object_taxonomies, get_attachment_taxonomies, get_post_taxonomies. … … 8 8 get_object_taxonomies() and get_attachment_taxonomies()call each other to evaluate WP_Post objects that are attachments. But get_attachment_taxonomies() just passes it back to get_object_taxonomies() after doing a lot of unneeded text parsing. 9 9 10 This circular dependency should be removed because a lot of other functions depend on get_object_taxonomies(). 10 This circular dependency should be removed because a lot of other functions depend on get_object_taxonomies(). But the patch suggested doesn't remove it so while I think it fixes it, I think for the long run we should go another direction. 11 12 It also doesn't address any of the issues I found below. I don't know if we are supposed to address this here or if I should open bug reports for each of the things I found below. 11 13 12 14 I tested the functions and I found issues with each of the functions and I have questions about how to approach fixing them.