WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37377 closed defect (bug) (fixed)

Fix docs and parameter name on `wp_attachment_is()`

Reported by: flixos90 Owned by: SergeyBiryukov
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.2
Component: Media Keywords: has-patch
Focuses: docs Cc:
PR Number:

Description

The docs for the parameter $post_id of wp_attachment_is() is incorrect. While it has correct type definitions, the description is not accurate. Also I would think the parameter should rather be called $post and have null as default, similar to usage in other functions.

Attachments (1)

37377.diff (859 bytes) - added by flixos90 3 years ago.

Download all attachments as: .zip

Change History (3)

@flixos90
3 years ago

#1 @flixos90
3 years ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 38068:

Docs: Correct $post parameter name and description for wp_attachment_is() and wp_attachment_is_image().

Props flixos90.
Fixes #37377.

Note: See TracTickets for help on using tickets.