WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #37378


Ignore:
Timestamp:
07/18/2016 11:49:05 AM (8 years ago)
Author:
ocean90
Comment:

With the new WP_Term_Query class the ORDER BY keyword is added automatically: trunk/src/wp-includes/class-wp-term-query.php?marks=605,621,624#L572​

This wasn't the case before: tags/4.5.3/src/wp-includes/taxonomy.php?marks=1512-1535,1598,1604,1612#L1589​. See also the meta handling which is now in WP_Term_Query::parse_orderby_meta().

@boonebgorges Should we strip any existing keywords before adding our own?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #37378

    • Property Status changed from new to reopened
    • Property Component changed from Query to Taxonomy
    • Property Milestone changed from Awaiting Review to 4.6
    • Property Keywords 2nd-opinion added

  • Ticket #37378 – Description

    initial v3  
    1 It seems altering the tax query $pieces['join'] or $pieces['orderby'] is breaking the query.
     1It seems altering the tax query `$pieces['join']` or `$pieces['orderby']` is breaking the query.
    22
    33The following function is from repository plugin [https://wordpress.org/plugins/simple-taxonomy-ordering/ Simple Taxonomy Ordering]. The plugin function works in 4.5.3., no errors.