WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #37384, comment 5


Ignore:
Timestamp:
08/18/2016 07:51:35 PM (8 years ago)
Author:
FolioVision
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #37384, comment 5

    initial v1  
    33In some ways, it would be easier to remove the p tags as you recommend. Here's what our discovery found: sometimes things in right column are wrapped in p tags, but sometimes not (in Options -> Discussion the top ones). P tags as well as Label tags have their own margins, which add up. Plus, TH and TD don't have the same paddings, as well as TDs and P tags don't have the same line height. If you count this together, it's a mess.
    44
    5 In line with @karmatosed's recommendation, we keep the p tag, I did some work on making preferences line up. In this case, every element is wrapped in P. For the moment it doesn't work with default WordPress admin but does work starting with a clean slate. I'm attaching an HTML example of clean WordPress preferences with each the content in each td wrapped in P.
     5[[Image(options-original-alignment.png)]]
     6
     7In line with @karmatosed's recommendation, we keep the p tag, I did some work on making preferences line up. In this case, every element is wrapped in P. For the moment it doesn't work with default WordPress admin but does work starting with a clean slate.
     8
     9[[Image(options-better-simpler-alignment.png)]]
     10
     11I'm attaching an HTML example of clean WordPress preferences with each the content in each td wrapped in P.
     12
     13https://core.trac.wordpress.org/attachment/ticket/37384/options-discussion-alignment.html
    614
    715.form-table cells include all different elements and tags. Right now many of them don't even share the same margins or paddings (like TH and TD). Every try to unify the tags one by one resulted in more work.