Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#37389 closed defect (bug) (fixed)

Incorrect WP_Error usage in WP_Tax_Query

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Priority: normal Milestone: 4.6
Component: Taxonomy Version: 3.2
Severity: normal Keywords:
Cc: Focuses:

Description

In WP_Tax_Query::clean_query() and WP_Tax_Query::transform_query(), strings are used as error codes:

$query = new WP_Error( 'Invalid taxonomy' );
...
$query = new WP_Error( 'Inexistent terms' );

Correct usage would be:

$query = new WP_Error( 'invalid_taxonomy', __( 'Invalid taxonomy.' ) );
...
$query = new WP_Error( 'inexistent_terms', __( 'Inexistent terms.' ) );

Introduced in [17686].

Change History (1)

#1 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status newclosed

In 38079:

Taxonomy: Correct WP_Error usage in WP_Tax_Query::clean_query() and WP_Tax_Query::transform_query().

Fixes #37389.

Note: See TracTickets for help on using tickets.