WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 13 months ago

Last modified 3 months ago

#37394 closed defect (bug) (fixed)

Update list of translatable strings for MediaElement.js

Reported by: ocean90 Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Media Keywords: reporter-feedback
Focuses: javascript Cc:

Description

Change History (9)

#1 @ocean90
13 months ago

  • Owner set to ocean90
  • Status changed from new to accepted

#2 @ocean90
13 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 38089:

Media: Update list of translatable strings for MediaElement.js.

Fixes #37394.

#3 @ocean90
13 months ago

In 38090:

Media: Add missing gettext to a string added in [38089].

See #37394.

#4 @SergeyBiryukov
13 months ago

In 38150:

I18N: Add a translator comment for two MediaElement.js strings added in [38089].

Props ideag.
See #37453, #37394.

#5 @johnbillion
13 months ago

  • Keywords reporter-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

The Jump forward %1 seconds string doesn't exist in MediaElement. It looks like the jumpforward feature of MEP isn't included in WordPress.

This should either be included, or the unused string should be removed.

Last edited 13 months ago by johnbillion (previous) (diff)

#6 @nacin
13 months ago

Yeah, we only include the default features. A bunch of them are not included by default, including jumpforward. This string should be removed. Someone including the plugin should include whatever strings they need.

#7 @nacin
13 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 38203:

MediaElement: Remove translated string from a plugin WP doesn't bundle.

fixes #37394.

#8 @pento
13 months ago

In 38204:

MediaElement: Remove translated string from a plugin WP doesn't bundle.

Merge of [38203] to the 4.6 branch.

Props nacin.
Fixes #37394.

#9 @swissspidy
3 months ago

In 40775:

Media: Correct a translatable string for MediaElement.js.

Adds the needed context to the string "None". Introduced in [38089].

Props leewillis77.
See #37394.
Fixes #40800.

Note: See TracTickets for help on using tickets.