WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#37410 closed defect (bug) (fixed)

grunt upload_patch fails when diff-cmd is colordiff

Reported by: pento Owned by: pento
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description

To reproduce:

  • Set your diff-cmd to colordiff
  • Use grunt upload_patch to upload a patch to a ticket.
  • lol.

Attachments (2)

37410.diff (448 bytes) - added by jorbin 4 years ago.
37410.2.diff (448 bytes) - added by pento 4 years ago.

Download all attachments as: .zip

Change History (8)

#2 @pento
4 years ago

  • Owner set to jorbin
  • Status changed from new to assigned

Yep, probably. @jorbin can decide where he wants to track it. :-)

#3 @jorbin
4 years ago

Ticket created for tracking the fix upstream. Will keep this open to track including the fix in WordPress.

@jorbin
4 years ago

#4 @netweb
4 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.6

@pento
4 years ago

#5 @pento
4 years ago

  • Owner changed from jorbin to pento

37410.2.diff uploaded correctly. ;-)

#6 @pento
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38111:

Tools: Update grunt-patch-wordpress to 0.4.2.

This update fixes invalid patches being uploaded to Trac when the diff-cmd is set to colordiff.

Props jorbin.
Fixes #37410.

Note: See TracTickets for help on using tickets.