![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 10 years ago
Closed 10 years ago
#37412 closed defect (bug) (fixed)
Change default value of $context to empty string for request_filesystem_credentials() and get_filesystem_method()
| Reported by: | ocean90 | Owned by: | ocean90 |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.6 |
| Component: | Filesystem API | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | docs |
Description
$context is a path to a directory and shouldn't be false by default.
Automatic_Upgrader_Skin::request_filesystem_credentials() and WP_Upgrader_Skin::request_filesystem_credentials() need to be updated too.
Attachments (3)
Change History (8)
This ticket was mentioned in Slack in #core by drew. View the logs.
10 years ago
#3
@
10 years ago
- Keywords has-patch added
@ocean90 Since we're changing the default for $context, 37412.diff adds changelog entries to the function DocBlocks and as well as DocBlocks for hooks that would additionally be affected by the change.
It might seem like a lot of ground to cover, but anybody relying on $context defaulting to false in the resulting hooks should get some kind of explanation.
Note:
See TracTickets
for help on using tickets.
@DrewAPicture How does 37412.2.patch look to you?