In WP_Comment_Query::fill_descendants() compute the size beforehand and not on each iteration

[ocean90]

Source: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-comment-query.php?rev=38001&marks=1015#L1013

Currently count() is called on each iteration.

[vishalkakadiya]

We need to go till end so needed $i <= $level_count, <= because loop is starting from 1.

[deremohan]

Calculating count inside "for" loop initialisation statement

[wonderboymusic]

In 38297:

Comments: in WP_Comment_Query::fill_descendants(), compute count() in the first for expression so that it does not run on each iteration.

Props vishalkakadiya, deremohan.
Fixes #37416.

[wonderboymusic]

In 38298:

Comments: in WP_Comment_Query::fill_descendants(), continue if there is an empty array in the loop.

See #37416, [38297].

[nacin]

Replying to wonderboymusic:

In 38298:

Comments: in WP_Comment_Query::fill_descendants(), continue if there is an empty array in the loop.

See #37416, [38297].

@wonderboymusic, was this necessary after [38297]? Or is this just another optimization on top of that?

[wonderboymusic]

@nacin notices were generated in PHP7

[ocean90]

@nacin See ​https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/153889644#L380.

[38298] isn't needed if the condition in [38297] wasn't changed from < to <=. Was there a reason for that? I don't think so since the index starts at 0.

[jorbin]

@ocean90 Do you want to write an update to revert the < to <= part of [38297]?

[ocean90]

In 38639:

Comments: Revert [38298].

Instead use the correct comparison operator which was changed in [38297].

Fixes #37416.