WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 7 months ago

#37420 closed enhancement (wontfix)

Enable TinyMCE for attachment descriptions

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords: 2nd-opinion
Focuses: Cc:

Description

Enabling TinyMCE for attachment descriptions was briefly mentioned in #24472, but it seems like it was never really discussed as a default option before.

[23083] introduced the current text editor with quick tags, before that it was just a simple textarea.

[28944] introduced the wp_editor_settings filter, so it should be possible to override 'tinymce' => false on the attachment editor instance.

Any reasons not to enable it by default?

Change History (5)

This ticket was mentioned in Slack in #core-media by desrosj. View the logs.


4 years ago

#2 follow-up: @desrosj
4 years ago

@SergeyBiryukov did you have any use cases in mind?

Talked this over in the media bug scrub today with @joemcgill. Are there any locations where the description is being sanitized and would cause something to break when HTML is included?

It is also a poor user experience that the attachment edit screen supports this (https://cloudup.com/c9dhHFtzLtl+) but the modal does not (https://cloudup.com/cT4IGkRXoEm+).

#3 in reply to: ↑ 2 @SergeyBiryukov
4 years ago

Replying to desrosj:

@SergeyBiryukov did you have any use cases in mind?

Must be a project I worked on or a support topic I answered at the time, but I could not find any additional details.

Talked this over in the media bug scrub today with @joemcgill. Are there any locations where the description is being sanitized and would cause something to break when HTML is included?

The field already has an HTML editor since [23083], it's just that quicktags.js is not as convenient as TinyMCE :)

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


7 months ago

#5 @antpb
7 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

This was brought up in a recent media scrub and the team agreed that enabling this by default would be undesirable if the Media modal could not offer the same editor.

@hellofromtonya mentioned
What about impacts to 3rd parties who are filtering the settings? Changing the default could have backwards-compat issues for them

Being that there is a filter to enable the option maybe it's best that we not default to the option.

Personally, I'd love to see a Gutenberg-like editor for descriptions but admittedly, probably best fit for a plugin. That might also be the case for this default. :)

Marking this maybelater feel free to open up again if it becomes "later"!

Note: See TracTickets for help on using tickets.