Add Plugins: Improve the error messages displaying

[afercia]

Minor visual improvements: in the Add Plugins screen, some error messages could use some love. For example, some messages can be very long: setting a max-width and increasing a bit the line-height could help. Also, on the responsive view, maybe the messages should not be displayed in the middle of the page but moved to the top.

For comparison, this is how the same message gets displayed in the Themes screens, so maybe worth considering also introducing a bit of consistency:

[ocean90]

The current design exists since 4.0. I agree that it should be improved, but it's not a regression.

[tinkerbelly]

Patch to improve error messaging on plugins page

[tinkerbelly]

"No plugins found" error message.

[tinkerbelly]

Error with patch applied

[tinkerbelly]

I tried my hand at a patch here: https://core.trac.wordpress.org/attachment/ticket/37430/patch.diff

It looks as though this error had been using the "no-plugins-results" CSS class, which then styled it the same way as that error message.

Screen Shot 2016-07-24 at 15.23.46.png​

Using a standard error class seems more sensible in this case. Here's what the error message looks like with the patch applied:

Screen Shot 2016-07-24 at 15.55.04.png​

I'm not certain the "try again" link is required here—it's not used on the same error on the themes page, and it would make sense to keep it consistent. It just refreshes the page; not sure how useful users find it.

[juhise]

In my opinion 'Try Again' should look like button not link. It is useful for users as this error is unexpected so user should have the feature to Try Again.

[juhise]

Patch

[juhise]

Patch

[Ankit K Gupta]

This error message appears when something wrong with server configuration and network connectivity as well.
In this case, Try again button would be helpful on theme-install.php same as plugin-install.php.

Adding patch for theme page Try again button.

[Ankit K Gupta]

Can we consider this ticket for 4.8 ?
Thanks!

[swissspidy]

37430.3.patch​ is for theme-install.php, not the plugin installer as the ticket suggests.

As for the implementation: a button should be a button, not a link with href="#". See ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/

Since we have ajax search already on the plugin install screen — can we do the reloading without a full page refresh?

[m1tk00]

Changed the error messages with the Wordpress messages bar.

[swissspidy]

@m1tk00 Finally got around to review your patch as requested. Sorry for the delay!

Instead of moving around <hr class="wp-header-end">, <div class="inline error"> can be used so the notice doesn't get relocated underneath the page title. I fixed this in 37430.diff​ and made a few optimizations here and there to further unify the error message.

---

Plugin error message:

Theme error message:

No plugin found:

No theme found:

[DrewAPicture]

Assigning ownership to mark the good-first-bug as "claimed".

[tinkerbelly]

This looks to be best solved by https://core.trac.wordpress.org/attachment/ticket/37430/37430.diff above; feel free to prompt me if there's any further action on my part needed here. :)

[mrahmadawais]

FIX: Consistent Lingo and Button Case

[mrahmadawais]

I went ahead and add consistent lingo for themes and plugins as well as the buttons in ref with other buttons.

Looking forward!

[danieltj]

Fixed grammar issue with 'try again' text

[danieltj]

In patch 37430.6.diff​...

On top of the patch by @swissspidy and @mrahmadawais - I've fixed a grammar issue.

Try a different search. doesn't make a lot of sense so I've changed it to Try a different search query. instead.

[swissspidy]

In 41608:

Plugins: Improve error messages on plugins screen.

This unifies the layout and wording of error messages on both the plugins screen and the themes screen.

Props tinkerbelly, juhise, Ankit K Gupta, m1tk00, swissspidy, mrahmadawais, danieltj.
Fixes #37430.

[swissspidy]

In 41609:

Plugins: Fix version number in docblock after [41608].

Props ocean90.
See #37430.

[afercia]

Please see follow up on #42231

[afercia]

In 41878:

Administration: Improve consistency of the "not found" strings.

Partially reverts [41608] restoring the original strings without the word query.

See #37430.
Fixes #42231.

[SergeyBiryukov]

In 41915:

Plugins: After [41608], make the markup in WP_Plugin_Install_List_Table::no_items() a bit more readable.

See #37430.

[SergeyBiryukov]

In 41916:

Plugins: Revert unintended change from [41915].

See #37430.