#37453 closed defect (bug) (fixed)
MediaElement.js: Missing plural forms for jump forward/back strings
Reported by: | ideag | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | Media | Keywords: | upstream |
Focuses: | javascript | Cc: |
Description
Function wp_default_scripts() (https://core.trac.wordpress.org/browser/trunk/src/wp-includes/script-loader.php#L353 and https://core.trac.wordpress.org/browser/trunk/src/wp-includes/script-loader.php#L354) does not properly use _n() and related functions for plural forms of its strings. It just uses a single, plural string with a placeholder for a number, i.e. __( 'Jump forward %1 seconds' )
.
While this works in English, it presents a problem when translating into languages that have more than one plural form, or more complicated rules for singular form usage. For example, in Lithuanian we also use singular form for 21, 1241 and any other number that ends with 1 (except for 11). And we have two plural forms - one for numbers ending with a zero, another for everything else. In current situation we can not have a proper translation here.
Change History (12)
This ticket was mentioned in Slack in #polyglots by pokeraitis. View the logs.
8 years ago
#2
@
8 years ago
- Component changed from I18N to Media
- Keywords upstream added
- Summary changed from wp_default_scripts() does not properly pluralize strings to MediaElement.js: Missing plural forms for jump forward/back strings
#4
follow-up:
↓ 5
@
8 years ago
Note that skipBackInterval
and jumpForwardInterval
are 30 by default, so unless someone changes the default values (which is possible, but unlikely), both strings would contain "30 seconds".
#5
in reply to:
↑ 4
@
8 years ago
Replying to SergeyBiryukov:
Note that
skipBackInterval
andjumpForwardInterval
are 30 by default, so unless someone changes the default values (which is possible, but unlikely), both strings would contain "30 seconds".
In that case, it would be helpful to provide these default values in translator comments.
Hello @ideag, those strings are the original strings which MediaElement.js (the library for the media player) is using:
ME.js doesn't support plural forms, so this should probably reported upstream.