Review usage of esc_attr_e()

[afercia]

Spotted a few places where esc_attr_e() is probably used not correctly, maybe worth double checking if there are more places:

Here it should probably be echo esc_url() and the URL should be translatable as done in other similar cases:

setup-config.php
<p id="logo"><a href="<?php esc_attr_e( 'https://wordpress.org/' ); ?>" ...

In the following cases the string are used for plain HTML text, they're not attributes:

revision.php
...
	<?php esc_attr_e( 'Compare any two revisions' ); ?>
</label>


comment.php
... <?php esc_attr_e( 'Edit' ); ?></a>
... <?php esc_attr_e( 'Cancel' ); ?></a>

[SergeyBiryukov]

Previously: #23334.

Here it should probably be echo esc_url() and the URL should be translatable as done in other similar cases:

setup-config.php
<p id="logo"><a href="<?php esc_attr_e( 'https://wordpress.org/' ); ?>" ...

esc_url() is not available at that point, see [23455].

[SergeyBiryukov]

Replying to SergeyBiryukov:

esc_url() is not available at that point, see [23455].

Apparently it is available since [28978] :)

[henry.wright]

I've been through the codebase and found the following places where esc_attr_e() is used incorrectly:

• wp-includes/media-template.php
• wp-admin/includes/revision.php
• wp-admin/comment.php
• wp-login.php
• wp-admin/theme-editor.php - Just need to remove white space
• wp-admin/setup-config.php

[henry.wright]

37457.diff fixes esc_attr_e() usage.

[johnbillion]

In 38424:

I18N: Correct various instances of incorrect usage of esc_attr_e().

Fixes #37457
Props henry.wright, afercia