WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 16 months ago

#37466 new enhancement

Add oEmbed support for Office Mix

Reported by: GunGeekATX Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch needs-refresh
Focuses: Cc:

Description

Office Mix is a Microsoft site where users can share Powerpoint presentations. The have oEmbed support (https://blogs.office.com/2015/02/24/sharing-mixes-social-networks-embedding-embed-ly-oembed/). It appears though that they're not respecting the maxwidth and maxheight parameters (https://mix.office.com/OEmbed?url=https%3A%2F%2Fmix.office.com%2Fwatch%2F2dhwh9vlfmfx&format=json&maxwidth=300&maxheight=200)

I'll add a patch to this and can try to track down a developer at Microsoft to look at the width & height so we can get this provider included in a future release.

Attachments (1)

37466.diff (833 bytes) - added by GunGeekATX 22 months ago.

Download all attachments as: .zip

Change History (3)

@GunGeekATX
22 months ago

#1 @swissspidy
22 months ago

Huh, I think that's the first time I've heard of OfficeMix. Looks like their support for oEmbed is fairly new and not even WordPress.com supports that provider.

We have a certain standard for oEmbed providers in core. In order to add a new one to the existing whitelist, they must:

  • be well-established, popular, and mainstream services,
  • properly and fully implement the oEmbed specification,
  • and clearly be a trusted provider.

See https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers for a more complete checklist.

Not respecting the maxwidth and maxheight parameters is clearly a bummer (see also #34737), so it would be good to be able to talk to their developers.

It's worth noting that OfficeMix embeds kinda already work in WordPress thanks to oEmbed discovery and OfficeMix using an <iframe>. I only encountered a few problems:

  • The iframe tries to add a WebTrends tracking cookie, which it can't because of the sandboxing
  • It tries to load some JavaScript which doesn't exist
  • It also runs some deprecated features according to the console log.

@GunGeekATX Thanks for your patch! Note that the table of oEmbed providers would need to be updated as well in the according DocBlock.

#2 @swissspidy
16 months ago

  • Keywords has-patch needs-refresh added
  • Milestone changed from Awaiting Review to Future Release

Here's the oEmbed announcement on the Office Blogs running on WordPress, showing a demo: https://blogs.office.com/2015/02/24/sharing-mixes-social-networks-embedding-embed-ly-oembed/

Apart from that, it looks like there's no documentation.

Note: See TracTickets for help on using tickets.