Context Navigation

← Previous Ticket
Next Ticket →

#37478 closed defect (bug) (fixed)

Customizer undefined property if widget area before/after values are empty

Reported by:	Clorith	Owned by:	westonruter
Priority:	normal	Milestone:	4.6
Component:	Customize	Version:	4.6
Severity:	normal	Keywords:	has-patch needs-testing
Cc:		Focuses:	javascript

Description

Introduced in r37322 the replace on widgetClasses casts a TypeError if all the before_widget, after_widget, before_title and after_title fields are declared as an empty string in a theme when registering a widget area through register_sidebar

A quick example registration;

<?php
register_sidebar( array(
        'name'          => __( 'Sidebar' ),
        'id'            => 'sidebar-1',
        'before_widget' => '',
        'after_widget'  => '',
        'before_title'  => '',
        'after_title'   => '',
) );

As reported by @stevengliebe in https://wordpress.org/support/topic/customizer-js-error-when-register_sidebar-beforeafter-arguments-empty

Attachments (1)

37478.0.diff (1.9 KB ) - added by westonruter 10 years ago.

Download all attachments as: .zip

Change History (6)

@westonruter
10 years ago

Attachment 37478.0.diff added

#1 @westonruter
10 years ago

Keywords has-patch needs-testing added
Milestone Awaiting Review → 4.6
Owner set to westonruter
Status new → accepted

@stevengliebe Please give 37478.0.diff a try.

#2 @stevengliebe
10 years ago

That solves it for me. Thanks for working on this.

This ticket was mentioned in Slack in #core-customize by ocean90. View the logs.

10 years ago

#4 @westonruter
10 years ago

Resolution → fixed
Status accepted → closed

In 38166:

Customize: Prevent customize-preview-widgets JS errors in preview if a sidebar is registered with empty before_widget/after_widget params.

Selective refresh will not be available for widgets when they lack these params, so previewing will fallback to full page refreshes. Sidebars registered as such should be rare so this accounts for an edge case.

Fixes #37478.

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.

10 years ago

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#37478 closed defect (bug) (fixed)

Customizer undefined property if widget area before/after values are empty

Description

Attachments (1)

Change History (6)

@westonruter 10 years ago

#1 @westonruter 10 years ago

#2 @stevengliebe 10 years ago

This ticket was mentioned in ​Slack in #core-customize by ocean90. ​View the logs. 10 years ago

#4 @westonruter 10 years ago

This ticket was mentioned in ​Slack in #core-customize by westonruter. ​View the logs. 10 years ago