WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#37481 closed defect (bug) (fixed)

TinyMCE: the inline toolbar position is off

Reported by: azaozz Owned by: iseulde
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.5.3
Component: TinyMCE Keywords:
Focuses: Cc:
PR Number:

Description

The calculation of the inline toolbar vertical position is not accurate when it is shown above the selected element.

Attachments (6)

toolbar.png (86.3 KB) - added by azaozz 3 years ago.
Bildschirmfoto 2016-08-06 um 18.39.47.png (14.3 KB) - added by iseulde 3 years ago.
toolbar1.png (88.3 KB) - added by azaozz 3 years ago.
toolbar2.png (111.0 KB) - added by azaozz 3 years ago.
toolbar3.png (138.5 KB) - added by azaozz 3 years ago.
toolbar4.png (140.8 KB) - added by azaozz 3 years ago.

Download all attachments as: .zip

Change History (16)

@azaozz
3 years ago

#1 @azaozz
3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 38160:

TinyMCE: fix the calculation for the inline toolbar vertical position.

Fixes #37481.

#2 @iseulde
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Since [38160] the above happens when a custom toolbar is positioned above text.

When did it change for images?

#3 @ocean90
3 years ago

  • Keywords needs-patch added
  • Status changed from reopened to reviewing

#4 @pbearne
3 years ago

how do you get a custom toolbar positioned above text?

This ticket was mentioned in Slack in #core by ocean90. View the logs.


3 years ago

#6 @ocean90
3 years ago

  • Owner changed from azaozz to iseulde

Per status meeting, @iseulde is working on it.

#7 @azaozz
3 years ago

Been trying to remember why we had to add that margin = 8 var there. Thinking this has something to do with the CSS.

Testing in inline editor that has the same settings like the "main" editor, it seems to position the toolbar properly.

@azaozz
3 years ago

@azaozz
3 years ago

@azaozz
3 years ago

@azaozz
3 years ago

This ticket was mentioned in Slack in #core by ocean90. View the logs.


3 years ago

#9 @ocean90
3 years ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from reviewing to closed

Re-closing as fixed due to no further feedback. If necessary a new ticket can be created and we can mark it for 4.7 or 4.6.1.

#10 @omerblink
3 years ago

  • Version changed from trunk to 4.5.3

http://image.prntscr.com/image/aa8ff5865e744f899b2515ffd3988ab4.png

Last edited 3 years ago by omerblink (previous) (diff)
Note: See TracTickets for help on using tickets.