Context Navigation

← Previous Ticket
Next Ticket →

#37488 closed defect (bug) (fixed)

Improve output buffering when used for request_filesystem_credentials()

Reported by:	ocean90	Owned by:	ocean90
Priority:	normal	Milestone:	4.6
Component:	Filesystem API	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

wp_ajax_delete_theme(), wp_ajax_delete_plugin(), delete_theme() and delete_plugins() wrap request_filesystem_credentials() in ob_start() and ob_end_clean(). But the later is used in a condition which can lead to unexpected results since it's not always called.

Attachments (1)

37488.patch (4.4 KB ) - added by ocean90 10 years ago.

Download all attachments as: .zip

Change History (4)

@ocean90
10 years ago

Attachment 37488.patch added

#1 @ocean90
10 years ago

Milestone Awaiting Review → 4.6

#2 @ocean90
10 years ago

Component Plugins → Filesystem API

#3 @ocean90
10 years ago

Owner set to ocean90
Resolution → fixed
Status new → closed

In 38167:

Filesystem API: Output buffering for request_filesystem_credentials() should wrap the function directly.

Previously ob_end_clean() was only called when the previous condition was successful which led to unexpected results when another output buffering was involved, like PHPUnit's.

Fixes #37488.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core