WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #37494


Ignore:
Timestamp:
07/28/2016 10:09:02 AM (5 years ago)
Author:
ocean90
Comment:

Hello @francescobagnoli, welcome to our Trac!

Thanks for your detailed report, I've added 37494.patch which includes your suggested fix.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #37494

    • Property Keywords has-patch added
    • Property Milestone changed from Awaiting Review to 4.6
    • Property Summary changed from Wordpress 4.6 Beta 4: Proxy setting not work to Proxy authentication is ignored by Requests
  • Ticket #37494 – Description

    initial v1  
    1919
    2020
    21 debugging i see in Requests_Proxy_HTTP class, $use_authentication property is always false and in curl_before_send() method if $use_authentication is false curl_setopt CURLOPT_PROXYUSERPWD is never setted. If I force $use_authentication to be true, everything works.
     21debugging i see in `Requests_Proxy_HTTP` class, `$use_authentication` property is always false and in `curl_before_send()` method if `$use_authentication` is false `curl_setopt` `CURLOPT_PROXYUSERPWD` is never set. If I force `$use_authentication` to be true, everything works.
    2222
    2323
     
    4747
    4848
    49 This because Requests_Proxy_HTTP set $use_authentication property to true, only if Requests_Proxy_HTTP::__construct() has 3 parameters
     49This because `Requests_Proxy_HTTP` set `$use_authentication` property to true, only if `Requests_Proxy_HTTP::__construct()` has 3 parameters
    5050
    5151{{{#!php