WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#37496 closed defect (bug) (fixed)

Replace _x() with __() and translators comments in wp-admin/network/settings.php

Reported by: ramiy's profile ramiy Owned by: johnbillion's profile johnbillion
Milestone: 4.7 Priority: normal
Severity: normal Version: 3.0
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Context function _x() is used to differ two similar strings with different meanings. Translators comments are used to describe %s placeholders.

The attached patch is replacing:

_x( '%s KB', 'File size in kilobytes' )

with:

/* translators: %s: File size in kilobytes */
__( '%s KB' ),

Attachments (1)

37496.patch​ (1.1 KB) - added by ramiy 7 years ago.

Download all attachments as: .zip

Change History (6)

@ramiy
7 years ago

#1 @ocean90
7 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Version set to 3.0

Introduced in [13796].

#2 @ramiy
7 years ago

  • Summary changed from Replace _x() with __() with translators comments in wp-admin/network/settings.php to Replace _x() with __() and translators comments in wp-admin/network/settings.php

#3 @johnbillion
7 years ago

  • Milestone changed from Future Release to 4.7
  • Owner set to johnbillion
  • Status changed from new to reviewing

#4 @ramiy
7 years ago

Related: #37777

#5 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 38322:

I18N: Replace unnecessary context with a translator comment for %s KB string on Network Settings screen.

Props ramiy.
Fixes #37496.

Note: See TracTickets for help on using tickets.